Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-1164] Fix function that renders language in the downloads table #5172

Merged

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Oct 16, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section

Description

Fixed Project > Data > Downloads table displaying wrong text in the "Language" column. This was happening when "XML values and headers" or "Labels" was selected in "Value and header format".

Notes

We broke this in #4933. It would be immediately spotted if /jsapp/js/components/projectDownloads was typescriptized.

Testing

Test this without fix first. The steps are:

  1. Create a small project
  2. Deploy project
  3. Add one submission
  4. Go to Poject > Data > Downloads
  5. Set "Value and header format" to "Labels" and click "Export"
  6. Observe export being added (after a short moment), and in the column "Language" you will see "_default" (:bug:)
  7. Set "Value and header format" to "XML values and headers" and click "Export"
  8. Observe export being added (after a short moment), and in the column "Language" you will see "_xml" (:bug:)

There is a screenshot at #5171

Related issues

Fixes #5171
Followup to #4933

@magicznyleszek magicznyleszek marked this pull request as ready for review October 16, 2024 12:42
@magicznyleszek magicznyleszek changed the title Fix function that renders language in the downloads table [TASK-1164] Fix function that renders language in the downloads table Oct 16, 2024
@jamesrkiger jamesrkiger merged commit 3ba0bad into release/2.024.33 Oct 16, 2024
7 checks passed
@magicznyleszek magicznyleszek deleted the release-2.024.33-task-1164-fix-export-labels branch October 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants